Re: PHP-5.5 unpack change broke pecl/pear

From: Date: Mon, 14 Jan 2013 04:35:51 +0000
Subject: Re: PHP-5.5 unpack change broke pecl/pear
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message 


On 12/28/2012 01:08 AM, Remi Collet wrote:

Le 24/12/2012 04:16, Igor Wiedler a écrit :

Hi Internals,

When test driving PHP-5.5 I ran into issues with a change of unpack behaviour. Archive_Tar which is used by pecl and pear (pecl install) uses unpack with the "a" format character. On 5.4 it strips trailing NUL bytes, on 5.5 it does not. There is a new "Z" format character that can be used to get the old behaviour. The point is, this change broke pecl, and will likely break many other things in existence.




Anthony has asked me to post to internals, so that you can re-visit the issue and perhaps consider not breaking BC.

If you decide that you want to keep the BC break, I will gladly submit a patch for Archive_Tar.


See http://pear.php.net/bugs/bug.php?id=19746

Remi.



Thanks,

Igor






Sherif,

Are you "owning" this issue?
I assigned bug https://bugs.php.net/bug.php?id=63073 to you in case you are.

Chris

-- 
[email protected]  http://twitter.com/ghrd
Newly updated, free PHP & Oracle book:
http://www.oracle.com/technetwork/topics/php/underground-php-oracle-manual-098250.html

Thread (11 messages)

« previous php.internals (#64921) next »