Re: Re: [PATCH] (v 5.4.11-dev) ext/date/php_date.c cleanup
On Fri, Dec 7, 2012 at 8:54 PM, Paul Taulborg <[email protected]> wrote:
> Sorry for the double message, still getting used to doing patches
> instead of applying changes directly. I accidentally attached an old
> patch file, not the latest. The previous had a bug in
> php_date_initialize() which I caught in my testing (I left the local
> variable tzi, by mistake, instead of using now->tz_info), but didn't
> regenerate the patch file. Caught up upon reviewing the patch itself
> and realizing it was the old one. :-/
>
> Attached is the proper patch, thanks.
>
> --
> PHP Internals - PHP Runtime Development Mailing List
> To unsubscribe, visit: http://www.php.net/unsub.php
>
Hi,
Could you open a bug on http://bugs.php.net/ and attach the patch
(or
create a pull request and link that)?
I think it would be also useful if you could split the changes into
separate two patches: one for the whitespace changes and one for the actual
code adjustments.
Thanks!
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu
Thread (3 messages)