Re: Re: [VOTE] Allow non-scalar keys in foreach
Hi Nikita,
few notes about the patch...
- you may avoid estrndup() in zend_hash_current_key_zval_ex() for interned
strings.
- I didn't completely get why did you change the "key" operand type from
IS_TMP_VAR to IS_VAR and how it affects performance
As I understood now you need to allocate new zval on each loop iteration
even for foreach over plain arrays. :(
Thanks. Dmitry.
On Wed, Mar 6, 2013 at 7:27 PM, Nikita Popov <[email protected]> wrote:
> On Wed, Feb 27, 2013 at 8:33 PM, Nikita Popov <[email protected]>
> wrote:
>
> > Hi internals!
> >interned strings
> > I've opened the voting the the foreach-keys RFC:
> >
> > https://wiki.php.net/rfc/foreach-non-scalar-keys#vote
> >
> > The discussion for this RFC can be found here:
> > http://markmail.org/message/rzoacqaesxbd67lu
> >
>
> The RFC was accepted unanimously, with 21 votes in favor. I'll merge the
> patch sometime soon.
>
> Thanks,
> Nikita
>
Thread (13 messages)