Re: Add a constant to reflect --with-curlwrappers

From: Date: Mon, 01 Apr 2013 09:33:51 +0000
Subject: Re: Add a constant to reflect --with-curlwrappers
References: 1 2  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
On 01.04.2013 01:18, Hannes Magnusson wrote:
>>    I propose to add a constant : bool CURL_WRAPPERS_ENABLE

+1 on a constant if it has to stay. We had to do pretty ugly stuff to
detect it in the composer installer
https://github.com/composer/getcomposer.org/blob/master/web/installer#L135-148

> The curl wrappers have always been a major pain, with plenty of bugs
> and we tend to forget to add context options there to match the
> standard wrapper on new feature.
> 
> It has been marked as experimental since forever, and I think its time
> to face the failed experiment and remove it.

+2 for just removing it. In my experience most/all people using it just
do so by accident, because they copy pasted a configure line that had it
enabled from somewhere 5 years ago and never looked back.

Cheers

-- 
Jordi Boggiano
@seldaek - http://nelm.io/jordi


Thread (64 messages)

« previous php.internals (#66880) next »