Re: Re: libmagic 5.14 upgrade
Stas,
I've invested more time and here's almost cleaned up patch
http://belski.net/phpz/finfo/finfo_5.14_10.patch.gz
The tests pass, valgrind is happy, as well Windows. I've noticed no
behaviour change, except - as the data is updated and one might see
different (eventually better) results.
Please take a look.
Regards
Anatol
On Wed, 2013-03-27 at 22:09 +0100, David Soria Parra wrote:
> On 03/27/2013 09:35 PM, Pierre Joye wrote:
>
> > We have done that many times in the past for 5.3 and 5.4. It is
> > relatively risk free. Even more for 5.5 during beta phase. It does not
> > add new features but fixes bugs.
> >
> > The good side effect is that we can test it well with 5.5 and back
> > port to 5.3/4 later.
>
> I consider it a feature and not a necessary bugfix. In addition anatoly
> is saying that there are still problems with the patch. Both are reasons
> for me to believe that upgrading it 1-1.5 month before a final is not
> worth the risk. I would prefer to be more strict about the "feature
> freeze" than we were with 5.3 and 5.4.
>
> David
>
>
Thread (11 messages)