Re: Adding E_WARNING to pg_unescape_bytea()

From: Date: Tue, 02 Jul 2013 07:56:39 +0000
Subject: Re: Adding E_WARNING to pg_unescape_bytea()
References: 1  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
Hi Yasuo,

> pg_unescape_bytea() should raise error for invalid inputs
> https://bugs.php.net/bug.php?id=65165
> 
> We need to discuss if E_WARING is proper, which branch should be
> changed.
> 
> It will not break working code, so I would like to use E_WARNING and
> change it from PHP 5.4.

Raising an E_WARNING will most likely mean that it needs to be
suppressed in some way, which I think is not necessary.

I'm all for returning false when the input is invalid. However, given
the behaviour change, I suppose it would be PHP 5.next material.


Cheers
-- 
Matteo Beccati

Development & Consulting - http://www.beccati.com/


Thread (3 messages)

« previous php.internals (#68030) next »