Re: com php-src: Merge from GitHub: ext/opcache/ZendAccelerator.c ext/opcache/ZendAccelerator.h
Hi Johannes,
I agree, this "-dev" suffix is annoying in PHP releases.
However, I don't see a simple way to avoid it.
I don't like to complicate PHP release process or increase OPcache version
on each release.
In my opinion, it would be good if in releases "-dev" would be
automatically substituted by PHP version (e.g. "7.0.3 (5.5.2)" instead of
"7.0.3-dev".
I hope it must be possible to do it using C preprocessor. May anyone take a
look into it and propose a patch?
Thanks. Dmitry.
On Sun, Jul 28, 2013 at 4:17 PM, Johannes Schlüter
<[email protected]>wrote:
> On Sun, 2013-07-28 at 09:47 +0000, Dmitry Stogov wrote:
> > index 733e544..5f414f2 100644
> > --- a/ext/opcache/ZendAccelerator.h
> > +++ b/ext/opcache/ZendAccelerator.h
> > @@ -27,7 +27,7 @@
> > #endif
> >
> > #define ACCELERATOR_PRODUCT_NAME "Zend OPcache"
> > -#define ACCELERATOR_VERSION "7.0.2-dev"
> > +#define ACCELERATOR_VERSION "7.0.3-dev"
>
> Having -dev versions stable branches in git is problematic as we most
> likely forget to change that before a release and users get "-dev"
> versions. Can we either remove the -dev or properly define this in
> README.RELEASE_PROCESS?
>
> johannes
>
>
>
Thread (5 messages)