Hi!
> Sorry for the long delay, I've sent pull requests
>
> https://github.com/php/php-src/pull/368
> https://github.com/php/php-src/pull/367
> https://github.com/php/php-src/pull/366
I'm looking at the pulls, and I see these issues:
1. session_id is still banned in strict mode. Can we not ban it? I think
it detracts significantly from usefulness of the patch, as it would
break a lot of legit code that takes session IDs not from cookies but
from other sources and thus have to use session_id.
2. I got segfault when running it on test
session_set_save_handler_class_005. Here's the backtrace:
0x003a4c6d in ps_files_path_create (buf=0xbfffdae4 "", buflen=1024,
data=0x0, key=0x286f95c "ba3c966548c65fb9dd0ad4d30972f2fa") at
/Users/smalyshev/php-5.5/ext/session/mod_files.c:76
76 if (key_len <= data->dirdepth ||
(gdb) bt
#0 0x003a4c6d in ps_files_path_create (buf=0xbfffdae4 "", buflen=1024,
data=0x0, key=0x286f95c "ba3c966548c65fb9dd0ad4d30972f2fa") at
/Users/smalyshev/php-5.5/ext/session/mod_files.c:76
#1 0x003a47f9 in ps_files_key_exists (data=0x0, key=0x286f95c
"ba3c966548c65fb9dd0ad4d30972f2fa") at
/Users/smalyshev/php-5.5/ext/session/mod_files.c:230
#2 0x003a46c8 in ps_create_sid_files (mod_data=0xc9ae94, newlen=0x0) at
/Users/smalyshev/php-5.5/ext/session/mod_files.c:468
#3 0x003960ef in zim_SessionHandler_create_sid (ht=0,
return_value=0x286f880, return_value_ptr=0xbfffe228, this_ptr=0x2868260,
return_value_used=1) at
/Users/smalyshev/php-5.5/ext/session/mod_user_class.c:155
Looks like module data is not initialized properly (which is the point
of the test) but the checks on ps_create_sid_files do not check it.
3. Also got some other test failures:
session_save_path_variation5
session_set_save_handler_class_012
session_set_save_handler_class_016
Didn't look into those yet.
--
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227