On Fri, Sep 27, 2013 at 7:11 AM, Sherif Ramadan <[email protected]>wrote:
>
>
>
> On Thu, Sep 26, 2013 at 6:51 PM, Tjerk Meesters <[email protected]>wrote:
>
>>
>>
>> I deliberately chose these values so that I can simply specify true to
>> mean pass both values. Bit masks seem cumbersome in this situation.
>>
>>
>
> The default behavior is already to pass the value to the callback.
> Requiring the argument only breaks backwards compatibility here. There is
> no need for introducing 3 new constants. Simply use PASS_KEY or PASS_BOTH
> to solve this problem with the default behavior is pass value if the
> argument is omitted.
>
I agree that only two constants are necessary here to accomplish the same
effect; I'll update the code.
I didn't quite understand how the current implementation would have BC
issues, though. Would you care to elaborate on that?