On Tue, Nov 5, 2013 at 7:03 PM, Julien Pauli <[email protected]> wrote:
> On Tue, Oct 29, 2013 at 9:40 AM, Ferenc Kovacs <[email protected]> wrote:
>
>>
>>
>>
>> On Tue, Oct 29, 2013 at 9:22 AM, Julien Pauli <[email protected]> wrote:
>>
>>> On Wed, Oct 23, 2013 at 8:57 PM, Sherif Ramadan <[email protected]
>>> >wrote:
>>>
>>> > On Thu, Oct 17, 2013 at 1:24 AM, David Soria Parra <[email protected]>
>>> wrote:
>>> >
>>> > > David Soria Parra <[email protected]> schrieb:
>>> > > > I think over the last years it proved to be good to have the
>>> current
>>> > > > RM support a new RM who then takes over after the final release
>>> > > > (e.g. Julien basically does 5.5 alone now, but we worked a lot
>>> together
>>> > > > during alpha/beta/RC). Therefore my suggestion is that Julien is
>>> going
>>> > to
>>> > > > help out with 5.6 and then we would need a new RM that can learn
>>> from
>>> > > julien
>>> > > > on how to do things to later be able to do 5.6 on his own.
>>> > >
>>> > > So I mabe think Ferenic (tyrael) would be a good RM.
>>> >
>>> >
>>> > I'm all for that as well :)
>>> >
>>> > +1
>>> >
>>>
>>> Hi back !
>>>
>>> I suggest we move forward on the topic.
>>>
>>> We're gonna enter November soon, this is a dead line to branch 5.6.
>>>
>>> I suggest we branch 5.6 from master, then run the 5.5 test suite against
>>> the branch, and remove every commit that leads to a BC break.
>>> The task shouldn't be too hard.
>>>
>>> When the branch is created, the wiki then would have to be updated to
>>> show
>>> the ideas we'd like to support (https://wiki.php.net/todo/php56)
>>>
>>> Julien Pauli
>>>
>>
>>
>> Hi,
>>
>> I was working on that last week, there are a couple of test related
>> changes which should/could be backported to 5.5 (and maybe even 5.4):
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=ecbe4af0de94c629fa5ba8ab169654e00c958bad
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=361e984e462de5422bba5470d3961e67de327396
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=95017c0522a9a1b9527d7cc1d866fbc3b89df7ac
>> I have sent an email to Sara/ptarjan, but got no response yet:
>> http://permalink.gmane.org/gmane.comp.php.cvs.general/62834
>>
>> The sole BC break I've found yet was the removal of $HTTP_RAW_POST_DATA
>> and co from Mike:
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=423c70fb4d79b7831b1db41ea217c8e1afd5cf8e
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=449d4c0b1c6ea0f5dfe7b56c99d9fc4f2033d27c
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=4a3936ef4abdeb72c7d323fe4b6a65e1ae0ef181
>>
>> http://git.php.net/?p=php-src.git;a=commitdiff;h=8d087dc0d7c88e26539646875dc0f7bb5042187b
>>
>> This would be a measurable improvement for many of our users with a
>> relatively easy way to restore/emulate the old behavior
>> ($HTTP_RAW_POST_DATA = file_get_contents("php://input");) so maybe it
>> should be worth a discussion whether or not we should revert it from 5.6..
>>
>
> Mmmm, that's a break anyway, even if we provide solutions against it.
> Can we afford it ?
>
I'm not fond of the idea myself, but I can see why others would disagree.
I will revert it from 5.6 though, and we can discuss it later.
>
>
> Anyway, we should branch this week please.
> I can give time this week to help on stuff, unfortunately I wont have time
> this week-end but next one :-p
>
I will branch it today from master (without the raw post data BC break).
--
Ferenc Kovács
@Tyr43l - http://tyrael.hu