Re: size_t and 64 bit integer branch
Hi Jakub,
On Sun, November 24, 2013 22:21, Jakub Zelenka wrote:
> I have been playing with openssl a bit and made it work with this
> configuration:
>
>
> --disable-all --enable-cli --enable-debug --with-openssl
>
>
> The commit is here
>
>
> https://github.com/bukka/php-src/commit/215811e3fdb7b4f2786576851c8687c62
> 49c4725
>
>
> It's just an initial work but it works fine for all tests. However there
> are lots of issues that need to be properly tested. I made notes about all
> possible issues that could be a problem:
>
> https://gist.github.com/bukka/7617548
>
>
> Lots of them are just possible loss of data that won't be really
> problematic but testing is required anyway IMHO. But some issues could be
> a problem and they need a proper testing.
>
> I currently work on my php-crypto ext that I plan to propose for PECL
> soon. So I will be doing testing for more versions of OpenSSL anyway. I
> could prepare some tests for edge cases and do it together though.
>
> Let me know what you think about the patch!
>
>
your patch looks fine. Unfortunately I've overseen your mail in the daily
flood and made some changes to openssl too. Why didn't you update the wiki
page by going on? It's exactly for the purpose of knowing what's currently
going on :) In any case, could you please merge with the current state and
do a PR? I'll merge it then.
One thing though about openssl and issues you mention in the gist - the
'int' vs. php_int_t overflows on 64 bit should be fixed on run time
checking against INT_MAX. Maybe that's what you could extend for the
openssl ext. That's an issue in many other libs too.
Thanks for you work
Anatol
Thread (8 messages)