+ 1 for the RFC
But if i'm not completely wrong, there is performance decrease instead of
increase in your tests?
https://gist.github.com/krakjoe/8444591
[joe@fiji php-src]$ sapi/cli/php isTest.php 10000
objects: 10000
arrayof: 0.00645113
instanceof: 0.00560713
$a = array_pop($foos);
//do something
foo($foos);
}
}
Is equivalent to
function foo(array $arr){
foreach($arr as $v){
if(!($v instanceof Foo)){
//trigger_error
}
}
if(count($foos) > 0){
$a = array_pop($foos);
//do something
foo($foos);
}
}
The check adds runtime complexity to the function for each call which is obviously not necessary (once would be good enough). And I doubt that users would actually make sure that the check is only performed once and even if you would argue that one should write it as follows:
function bar(Foo[] $foos){
foo($foos);
}
function foo(array $foos){
if(count($foos) > 0){
$a = array_pop($foos);
//do something
foo($foos);
}
}
Then it is still bad design compared to a collection which actually does the check during the addition of elements.
Although, I like the effort to make PHP somewhat more type safe I am -1 for this RFC, the implementation respectively. If we want typed arrays then the array needs to carry the type to be efficient.