Re: [RFC] [accepted] ldap_modify_batch

From: Date: Thu, 16 Jan 2014 15:04:35 +0000
Subject: Re: [RFC] [accepted] ldap_modify_batch
References: 1  Groups: php.internals 
Request: Send a blank email to [email protected] to get a copy of this message
On Thu, 2014-01-16 at 15:17 +0100, Ondřej Hošek wrote:
> Hello,
> 
> today, voting for ldap_modify_batch [1] ended with 5 votes in favor
> and none against.

Congrats to your first contribution!

> I have two questions regarding the rest of the process, given that
> this is my first contribution to the PHP project:
> 
> 1. What would be the easiest way to supply the changes to the project?
> Open a pull request on Github? Send a patch to someone?

Definitely open a PR on github, that should be the easiest.

> 2. Which version should ldap_modify_batch land in? Only in 5.6 or will
> it be backported? Against which branch should I submit the pull
> request or patch? (master? 5.5 (newest stable)? 5.3 (oldest supported
> stable)? earliest possible?)

Definitely not in 5.3, probably not in 5.4 and IMO fine for 5.5.
So whatever RMs think is appropriate, either 5.5 or 5.6, RMs?


-- 
Regards,
Mike



Thread (6 messages)

« previous php.internals (#71187) next »