Hi Chris,
On Wed, February 26, 2014 10:48, Chris Wright wrote:
> On 22 February 2014 00:31, Chris Wright <[email protected]> wrote:
>
>> Following on from this thread and Daniel's excellent work on TLS
>> improvements, and liaising heavily with Daniel off-list, I have created a
>> PR [1] of some work I have done to get peer verification
>> working with Windows native certificate store.
>>
>> This is by far and away the most preferable option as it gives "out of
>> the box" support for peer verification by default on Windows, and does
>> not require any additional certificate bundles or configuration. It also
>> allows us to take advantage of trust updates rolled out via MS update
>> systems.
>>
>> The implementation is complete in that it supports all existing
>> features, although it needs a little polishing and some edge cases
>> covering before it can be merged. The only definite known issue at the
>> time of writing is that the method for fetching the CN from the
>> certificate incorrectly assumes that the returned data will always be
>> UTF-8 encoded, a solution for this is planned and will be implemented
>> in the next day or two.
>>
>> I am by no means an expert on the subject matter here in any respect,
>> so I encourage ruthless code review.
>>
>> Note that there are no new features here, it is simply looking to fill
>> in the gaps in the recent work by providing consistency on Windows.
>>
>> [1] https://github.com/php/php-src/pull/601
>>
>
> This patch is now merged (thanks Daniel) and will be available in the
> next alpha. If anyone finds anything that doesn't behave as expected,
> please let me know.
>
the tests with the removed pcntl dependencies do fail for me. I made a
small change here
http://git.php.net/?p=php-src.git;a=commitdiff;h=56cbe043810ab773605aa6a6ca2eb362ea9a54e9
but still there are some with the similar diff
TEST 43/79
[C:\php-sdk\php56\vc11\x64\php-src\ext\openssl\tests\bug65538_001.phpt]
========DIFF========
001+ Warning: file_get_contents(https://127.0.0.1:64321/): failed to open
stream: No connection could be made because the target machine actively
refused it.
001- string(12) "Hello World!"
002+ in
C:\php-sdk\php56\vc11\x64\php-src\ext\openssl\tests\ServerClientTestCase.inc(93)
: eval()'d code on line 8
003+ bool(false)
========DONE========
Actually it's great to get rid of that pcntl dependency there, just we
should bring it inline. Working on the further fixes.
Regards
Anatol