Re: Pull Request #595

From:	Stas Malyshev	Date:	Sun, 06 Apr 2014 23:58:13 +0000
Subject:	Re: Pull Request #595
References:	1	Groups:	php.internals
Request:	Send a blank email to [email protected] to get a copy of this message

Hi!

> I'm here to request that my pull request #595 get merged.  It's a fix for
> bug #52384 regarding PDO::debugDumpParams().  I've put the code and a phpt
> into the PR.  You'll notice in the PR that the Travis CI build failed but
> after investigating, my test did not fail.  It looks as though it was due
> to other code.  This is my first time making a contribution so feel free to
> let me know if there's anything else I need to add.  Thanks!

There are some notes on the pull, mainly about code style but also on
substance. Could you look at them and try to address them?

-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227


   

Thread (6 messages)

• Chad ScribnerSat, 22 Mar 2014 02:29:54 +0000
  • Sherif RamadanSat, 22 Mar 2014 15:04:56 +0000
    • Chad ScribnerSat, 22 Mar 2014 15:13:51 +0000
      • Sherif RamadanSat, 22 Mar 2014 16:16:01 +0000
  • Stas MalyshevSun, 06 Apr 2014 23:58:13 +0000
    • Chad ScribnerTue, 08 Apr 2014 12:46:09 +0000