pgsql: Fix bogus comment that claimed that the new BACKUP METHOD line i

Lists: pgsql-committerspgsql-hackers
From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)postgresql(dot)org
Subject: pgsql: Fix bogus comment that claimed that the new BACKUP METHOD line i
Date: 2011-08-16 09:24:13
Message-ID: [email protected]
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

Fix bogus comment that claimed that the new BACKUP METHOD line in
backup_label was new in 9.0. Spotted by Fujii Masao.

Branch
------
master

Details
-------
http://git.postgresql.org/pg/commitdiff/2877c67bc24510c30bca477c876f5de427c85588

Modified Files
--------------
src/backend/access/transam/xlog.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)


From: Fujii Masao <masao(dot)fujii(at)gmail(dot)com>
To: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: [COMMITTERS] pgsql: Fix bogus comment that claimed that the new BACKUP METHOD line i
Date: 2011-08-17 04:40:34
Message-ID: CAHGQGwET_75PnsSnGLHMN-s5zByuB5v9n+si0VvXXtL9EdKL1w@mail.gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Lists: pgsql-committers pgsql-hackers

On Tue, Aug 16, 2011 at 6:24 PM, Heikki Linnakangas
<heikki(dot)linnakangas(at)iki(dot)fi> wrote:
> Fix bogus comment that claimed that the new BACKUP METHOD line in
> backup_label was new in 9.0. Spotted by Fujii Masao.

Thanks for fixing that.

What about the remaining of the patch which I submitted? Unless I'm missing
something, the patch enables us to handle correctly the case where recovery
starts from the backup using pg_basebackup, without adding new field like
backupEndRequired into pg_control. Since it doesn't change the content of
pg_control, it's applicable to v9.1, I think.

Regards,

--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source Software Center