Use bytes or %r to handle paths and process output #766
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paths are not ASCII, paths are not Unicode. Paths are bytes.
This PR handles paths like they are bytes, well at least the
current working directory. Handling paths and process output as
if they are unicode will introduce errors when paths are not
valid unicode. I tested this by creating a directory named
Which is not valid unicode, and tricks most python string
decoders into throwing an exception.
Fixes #710, maybe