Fix mbed compile --flash #846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unknown error is thrown while executing mbed compile --flash: [mbed] ERROR: Unknown Error: local variable 'baudrate' referenced before assignment Add the required argument to compile_ method. This also fixes another error while mbed compile --flash --baudrate 9600: [mbed] ERROR: Unknown Error: compile_() got an unexpected keyword argument 'baudrate' This is a regression introduced by #837
|
@theotherjimmy, @screamerbg: please consider this for 1.9.1: the regression in 1.9.0 was reported by various development teams in Cypress. |
|
Thanks for reporting this. I'll address it shortly. |
bridadan
approved these changes
Feb 13, 2019
screamerbg
approved these changes
Feb 13, 2019
Merged
|
Thanks. 1.9.1 is out with this patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unknown error is thrown while executing mbed compile --flash:
[mbed] ERROR: Unknown Error: local variable 'baudrate' referenced before assignment
Add the required argument to compile_ method.
This also fixes another error while mbed compile --flash --baudrate 9600:
[mbed] ERROR: Unknown Error: compile_() got an unexpected keyword argument 'baudrate'
This is a regression introduced by #837