Skip to content

Cellular: C030_N2XX default interface #10179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 22, 2019
Merged

Cellular: C030_N2XX default interface #10179

merged 1 commit into from
Mar 22, 2019

Conversation

mudassar-ublox
Copy link
Contributor

Description

Added missing provide-default / get_default_instance() mechanism in UBLOX_N2XX driver.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

Release Notes

@mudassar-ublox mudassar-ublox mentioned this pull request Mar 21, 2019
Closed
@ciarmcom ciarmcom requested review from a team March 21, 2019 08:00
@ciarmcom
Copy link
Member

@mudassar-ublox, thank you for your changes.
@ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 21, 2019

Test run: FAILED

Summary: 2 of 13 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test
  • jenkins-ci/mbed-os-ci_exporter

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 21, 2019

CI restarted (exporter failure is license server issue, test passed it seems in the artifacts)

@0xc0170 0xc0170 merged commit 1d8c3d4 into ARMmbed:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@AriParkkila AriParkkila AriParkkila approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.12.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@mudassar-ublox @ciarmcom @0xc0170 @mbed-ci @AriParkkila @cmonr