Skip to content

PSoC6 serial driver: Setup RTS and TX lines on deepsleep entry/exit #10268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2019
Merged

PSoC6 serial driver: Setup RTS and TX lines on deepsleep entry/exit #10268

merged 1 commit into from
Apr 10, 2019

Conversation

cy-vivekp
Copy link
Contributor

Description

When PSoC6 enters deepsleep

  • Configure RTS and TX GPIO DR register to drive output (high)
    When PSoC6 exits deepsleep
  • Return SCB control on TX and RTS pins

Pull request type

[ ] Fix
[ ] Refactor
[X] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@satya1957 @svozcy @cydriftcloud

Release Notes

@cy-vivekp
PSoC uart: Setup RTS and TX lines in deepsleep
96b6f99 
When PSoC enters deepsleep, in uart driver
  - deassert RTS, set RTS to output high
  - set TX to output high
@ciarmcom
Copy link
Member

@cy-vivekp, thank you for your changes.
@ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team March 29, 2019 02:00
@cmonr
Copy link
Contributor

cmonr commented Mar 29, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Mar 30, 2019

Test run: SUCCESS

Summary: 13 of 13 test jobs passed
Build number : 1
Build artifacts

@NirSonnenschein
Copy link
Contributor

CI has passed on this one: @satya1957 @svozcy @cydriftcloud would you like to review this before it is merged?

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

@satya1957 @svozcy @cydriftcloud Please review.

@cmonr
Copy link
Contributor

cmonr commented Apr 9, 2019

CI restarted since results are now stale

@mbed-ci
Copy link

mbed-ci commented Apr 9, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 10, 2019

Waiting for approvals from reviewers

svozcy
svozcy approved these changes Apr 10, 2019
View reviewed changes
Copy link

@svozcy svozcy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes looks good for me!

@0xc0170 0xc0170 merged commit ffe9ddf into ARMmbed:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@satya1957 satya1957 Awaiting requested review from satya1957

@cydriftcloud cydriftcloud Awaiting requested review from cydriftcloud

2 more reviewers

@cmonr cmonr cmonr approved these changes

@svozcy svozcy svozcy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.12.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@cy-vivekp @ciarmcom @cmonr @mbed-ci @NirSonnenschein @0xc0170 @svozcy