Revert "K64F, STM32F429: IAR linker scripts dynamic heap fix" #11013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Jul 10, 2019
|
One request: do we know why it broke and with this revert what we are loosing? This would worth providing in the commit msg. |
|
Comment updated |
|
Also add to the commit msg (amend it) |
|
CI started will add details to the merge commit |
jeromecoutant
approved these changes
Jul 10, 2019
due to side effect with K64F bootloader application jump after three consecutive HW resets.
tymoteuszblochmobica
force-pushed
the
revert-10938-iar
branch
from
3a936ff to
878c936
Compare
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
mmahadevan108
approved these changes
Jul 10, 2019
|
Empty greentea-test results |
0xc0170
approved these changes
Jul 11, 2019
|
CI restarted |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #10938 due to K64F bootloader reset side effect
If heap dynamic allocation is enabled for IAR, bootloader fails to verify application after 3 consecutive HW resets.
Further root cause investigation is needed for this issue however to avoid blocking of 5.13.1 release this PR is reverted.
@0xc0170