Fix SAADC resolution for nRF52-based targets... again #11062
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AGlass0fMilk, thank you for your changes. |
SeppoTakalo
approved these changes
Jul 19, 2019
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
SeppoTakalo
added
ready for merge
release-version: 5.13.2
and removed
needs: CI
needs: review
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Somehow this bug reoccurred. The ADC HAL started using the legacy configuration
definesrather than the newNRFX_-prefixed ones introduced in SDK15.See #10939 for details on the original bug. This patches the other SAADC configuration macros.
Pull request type
Reviewers
@bulislaw
@0xc0170
Release Notes