Implement queue.count() #11145
Merged
Implement queue.count() #11145
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
requested review from
a team,
0xc0170,
jamesbeyond,
maciejbocianski and
mprse
|
@Tharazi97, thank you for your changes. |
Tharazi97
force-pushed
the
CountFunctionQueue
branch
from
1b7df63 to
4ce0bb1
Compare
evedon
requested changes
Aug 1, 2019
rtos/Queue.h
Outdated
| return osMessageQueueGetSpace(_id) == 0; | ||
| } | ||
|
|
||
| /** Check the quantity of items in queue. |
There was a problem hiding this comment.
It is not really a check. To be more precise, you could write:
"Get number of queued messages in the queue"
and
@return Number of items in the queue
Tharazi97
force-pushed
the
CountFunctionQueue
branch
from
4ce0bb1 to
32bdde5
Compare
evedon
approved these changes
Aug 2, 2019
|
@Tharazi97 Please mark this code change as functionality change and docs update. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
SeppoTakalo
added
ready for merge
release-version: 5.14.0-rc1
and removed
needs: CI
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements queue.count() which returns amount of items in the queue. As it is asked in: #10535
Pull request type
Reviewers
@Terryvanderjagt @maciejbocianski @jamesbeyond @0xc0170 @mprse
Release Notes