Skip to content

Conversation

AriParkkila
Copy link

@AriParkkila AriParkkila commented Dec 3, 2019

Description

Summary of change

Fix ATHandler::read_string/skip_param/read_hex_string to handle sequence "".
Fix ATHandler::write_hex_string to have quotation marks.

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@mirelachirica


Release Notes

Summary of changes

Impact of changes

Migration actions required

@AriParkkila
Copy link
Author

what about useQuatations parameter as for read_string(...)

@mirelachirica That's likely needed at some point but not right now, and since that'd be an API change it's better to fix the default to conform to 3GPP TS 27.007.

@ciarmcom ciarmcom requested review from a team and mirelachirica December 3, 2019 12:00
@ciarmcom
Copy link
Member

ciarmcom commented Dec 3, 2019

@AriParkkila, thank you for your changes.
@mirelachirica @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 added release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0 and removed needs: CI labels Dec 3, 2019
@0xc0170 0xc0170 merged commit e4e6ac5 into ARMmbed:master Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-version: 6.0.0-alpha-1 First pre-release version of 6.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants