Cellular: Replace UARTSerial references with BufferedSerial

[hugueskamba]

Summary of changes

BufferedSerial is UARTSerial renamed to convey the original purpose
of the class. It is the recommended buffered I/O serial class.

Impact of changes

Migration actions required

Documentation

---

Pull request type

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

@AnttiKauppila

---

[ciarmcom]

@hugueskamba, thank you for your changes.
@AnttiKauppila @ARMmbed/mbed-os-wan @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

Similar failure than in another ESP PR

[AnttiKauppila]

You should remove drivers/ from path where used because it is not be needed

[hugueskamba]

You should remove drivers/ from path where used because it is not be needed

@AnttiKauppila
Mentioning it once to account for all should have been sufficient. 😊
It was added not because of a need but rather because it makes it very clear which library it is included from.
In any case, it has been removed if you prefer not to have it. 👍

[0xc0170]

I believe it is preferred to use more explicit include path, including the module. Not considering how our tools work (including a lot), when we use anything else, this will still stand and work without any troubles. Otherwise we might have some surprises with some tools. I would expect this to be in our guidelines. I've just checked, it's there:

Always include header files using the module directory in the path. For example: #include “lwip/lwip-interface.h”, #include “drivers/Ticker.h”. Limit the include path to the module directory. This allows moving the module in the future.

We already updated platform/drivers code.

[hugueskamba]

I believe it is preferred to use more explicit include path, including the module. Not considering how our tools work (including a lot), when we use anything else, this will still stand and work without any troubles. I would expect this to be in our guidelines. I've just checked, it's there:

Always include header files using the module directory in the path. For example: #include “lwip/lwip-interface.h”, #include “drivers/Ticker.h”. Limit the include path to the module directory. This allows moving the module in the future.

We already updated platform/drivers code.

@AnttiKauppila @0xc0170 Should I revert back to what I had originally (it takes me no time)?

[evedon]

I believe it is preferred to use more explicit include path, including the module. Not considering how our tools work (including a lot), when we use anything else, this will still stand and work without any troubles. I would expect this to be in our guidelines. I've just checked, it's there:

Always include header files using the module directory in the path. For example: #include “lwip/lwip-interface.h”, #include “drivers/Ticker.h”. Limit the include path to the module directory. This allows moving the module in the future.

We already updated platform/drivers code.

@AnttiKauppila @0xc0170 Should I revert back to what I had originally (it takes me no time)?

While working on public headers clean-up this summer, we started to update mbed-os core code with more explicit include paths that specify the module.
@hugueskamba Please revert back to what you had originally

[hugueskamba]

@hugueskamba Please revert back to what you had originally

Done.

[0xc0170]

CI started

[mbed-ci]

Test run: FAILED

Summary: 1 of 4 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

• jenkins-ci/mbed-os-ci_unittests

[0xc0170]

Please review failures

[2020-01-16T14:08:51.258Z] /builds/ws/mbed-os-ci_unittests@2/unitTest-4999/mbed-os/UNITTESTS/stubs/BufferedSerial_stub.cpp:103:29: error: no ‘void mbed::BufferedSerial::unlock()’ member function declared in class ‘mbed::BufferedSerial’

[2020-01-16T14:08:51.258Z]  void BufferedSerial::unlock()

[hugueskamba]

UNITTESTS/stubs/BufferedSerial_stub.cpp

Thank you. This should fix it.

[0xc0170]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts