Skip to content

Refactor device_key #13433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 24, 2020
Merged

Refactor device_key #13433

merged 3 commits into from
Aug 24, 2020

Conversation

LDong-Arm
Copy link
Contributor

Summary of changes

As per our new directory restructure, this PR moves device_key from features into drivers and refactors its internal structure to

drivers
├── [...]
└── device_key
    ├── mbed_lib.json                                     
    ├── README.md
    ├── include
    │   └── device_key 
    │       └── DeviceKey.h
    ├── source
    │   └── DeviceKey.cpp
    └── tests
        └── TESTS

Impact of changes

None.

Migration actions required

None.

Documentation

None.

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@ARMmbed/mbed-os-core @rajkan01

@LDong-Arm
Move device_key into drivers
ccacd5c
@LDong-Arm
Restruture device_key
3681a87 
Restructure device_key to have
* include/device_key - header
* source - source file
* tests/TESTS - Greentea test
@LDong-Arm LDong-Arm changed the title Refactor device key Refactor device_key Aug 14, 2020
@mergify mergify bot added the needs: work label Aug 14, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 14, 2020
@ciarmcom ciarmcom requested review from a team and rajkan01 August 14, 2020 17:00
@ciarmcom
Copy link
Member

@LDong-Arm, thank you for your changes.
@rajkan01 @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot removed the needs: review label Aug 14, 2020
rajkan01
rajkan01 reviewed Aug 14, 2020
View reviewed changes
@LDong-Arm LDong-Arm force-pushed the refactor_device_key branch from 65659e9 to e8c35f8 Compare August 17, 2020 08:49
@LDong-Arm LDong-Arm requested a review from rajkan01 August 17, 2020 08:49
LDong-Arm
LDong-Arm commented Aug 17, 2020
View reviewed changes
@LDong-Arm LDong-Arm force-pushed the refactor_device_key branch from e8c35f8 to a59bace Compare August 17, 2020 09:14
rajkan01
rajkan01 approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LDong-Arm
Copy link
Contributor Author

@adbridge @0xc0170 Hi, this should be ready for CI, cheers

@mergify mergify bot added needs: CI and removed needs: work labels Aug 24, 2020
@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Aug 24, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@adbridge adbridge merged commit 4ba1a54 into ARMmbed:master Aug 24, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@evedon evedon evedon approved these changes

+1 more reviewer

@rajkan01 rajkan01 rajkan01 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 6.3.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@LDong-Arm @ciarmcom @adbridge @mbed-ci @0xc0170 @evedon @rajkan01 @mbedmain