Skip to content

CMake: Add support for WICED target #13972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 11, 2020
Merged

CMake: Add support for WICED target #13972

merged 1 commit into from
Dec 11, 2020

Conversation

hugueskamba
Copy link
Collaborator

Summary of changes

  • Add CMakeLists.txt file
  • Update the list of supported target

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

MarceloSalazar
MarceloSalazar reviewed Nov 26, 2020
View reviewed changes
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Nov 26, 2020
@ciarmcom ciarmcom requested review from a team November 26, 2020 18:00
@ciarmcom
Copy link
Member

@hugueskamba, thank you for your changes.
@ARMmbed/mbed-os-tools @ARMmbed/team-seeed @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Nov 27, 2020
View reviewed changes
@mergify
Copy link

mergify bot commented Nov 27, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot removed the needs: CI label Nov 27, 2020
@hugueskamba hugueskamba force-pushed the hk_cmake_wiced_suppport branch from 46342db to b270336 Compare November 27, 2020 11:32
@mergify mergify bot dismissed 0xc0170’s stale review November 27, 2020 11:33

Pull request has been modified.

@hugueskamba hugueskamba requested a review from 0xc0170 November 27, 2020 11:33
0xc0170
0xc0170 previously approved these changes Nov 27, 2020
View reviewed changes
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 27, 2020

CI started

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 30, 2020

CI was aborted, I restarted it.

@mergify
Copy link

mergify bot commented Dec 1, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot added needs: work and removed needs: CI labels Dec 1, 2020
@hugueskamba
CMake: Add support for WICED target
b4bc521 
* Add CMakeLists.txt file
* Update the list of supported target
@hugueskamba hugueskamba force-pushed the hk_cmake_wiced_suppport branch from b270336 to b4bc521 Compare December 1, 2020 15:05
@mergify mergify bot dismissed 0xc0170’s stale review December 1, 2020 15:06

Pull request has been modified.

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 1, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 2, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ❌
jenkins-ci/mbed-os-ci_greentea-test ❌

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 2, 2020

2 devices reported ERROR, we are investigating

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 2, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Dec 2, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 3 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️
jenkins-ci/mbed-os-ci_greentea-test ❌

@mergify mergify bot added needs: work and removed needs: CI labels Dec 2, 2020
@mergify
Copy link

mergify bot commented Dec 7, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@0xc0170 0xc0170 mentioned this pull request Dec 10, 2020
Merged
@0xc0170
Copy link
Contributor

0xc0170 commented Dec 10, 2020

This PR goes in via #14024

@0xc0170 0xc0170 merged commit ae74aa6 into ARMmbed:master Dec 11, 2020
@hugueskamba hugueskamba deleted the hk_cmake_wiced_suppport branch December 11, 2020 09:46
@mbedmain mbedmain added release-version: 6.6.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 left review comments

@jeromecoutant jeromecoutant Awaiting requested review from jeromecoutant

@rajkan01 rajkan01 Awaiting requested review from rajkan01

+2 more reviewers

@MarceloSalazar MarceloSalazar MarceloSalazar left review comments

@40Grit 40Grit 40Grit left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

needs: work release-version: 6.6.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@hugueskamba @ciarmcom @0xc0170 @mbed-ci @MarceloSalazar @40Grit @mbedmain