[mbed-os-5.15] Fix mbed device-management command for Python 3.8
#14057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teetak01
approved these changes
Dec 16, 2020
0xc0170
previously approved these changes
Dec 16, 2020
|
CI started |
Test run: FAILEDSummary: 1 of 10 test jobs failed Failed test jobs:
|
|
This pull request has automatically been marked as stale because it has had no recent activity. @ARMmbed/mbed-os-maintainers, please start CI to get the PR merged. |
|
We hopefully run 5.15 jobs later today to make this forward. |
Bump the `future` module version to 0.18.0 to fix an ImportError present for Python 3.8: ImportError: cannot import name 'splitattr' from 'urllib.request' (/usr/lib/python3.8/urllib/request.py)
artokin
force-pushed
the
device_management_sync_5_15
branch
from
4083606 to
1165fa7
Compare
|
rebased |
|
CI started |
Test run: SUCCESSSummary: 10 of 10 test jobs passed |
0xc0170
approved these changes
Jan 21, 2021
0xc0170
added
release-version: 5.15.7
ready for merge
and removed
needs: CI
release-version: 5.15.7
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Bump the
futuremodule version to 0.18.0 to fix anImportErrorpresent for Python 3.8:The upstream issue for the
futuremodule -- PythonCharmers/python-future#447. Fixed inv0.18.0.Fixes #14037.
Copied from master PR #14038
Impact of changes
Migration actions required
Documentation
None
Pull request type
Test results
Reviewers
@0xc0170