Analog Devices: refactor CMake targets #14244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
hugueskamba
previously requested changes
Feb 11, 2021
|
I'll rebase all of my PRs soon, on it |
0xc0170
force-pushed
the
cmake-refactor-analog-devices
branch
from
d8fd18d to
ab7067d
Compare
|
Rebased and fixed |
mergify
bot
dismissed
hugueskamba’s stale review
Pull request has been modified.
hugueskamba
reviewed
Feb 11, 2021
| bsp/xint/adi_xint.c | ||
|
|
||
| ${STARTUP_FILE} | ||
| ) |
There was a problem hiding this comment.
Please link mbed-aducm4050 with mbed-analog-devices here.
| device/startup_ADuCM4050.c | ||
| ) | ||
|
|
||
| target_link_libraries(mbed-ev-cog-ad4050lz INTERFACE mbed-analog-devices mbed-aducm4050) |
There was a problem hiding this comment.
Suggested change
| target_link_libraries(mbed-ev-cog-ad4050lz INTERFACE mbed-analog-devices mbed-aducm4050) | |
| target_link_libraries(mbed-ev-cog-ad4050lz INTERFACE mbed-aducm4050) |
| bsp/xint/adi_xint.c | ||
|
|
||
| ${STARTUP_FILE} | ||
| ) |
There was a problem hiding this comment.
Please link mbed-aducm3029 with mbed-analog-devices here.
|
Fixed all |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
hugueskamba
previously requested changes
Feb 15, 2021
mergify
bot
dismissed
hugueskamba’s stale review
Pull request has been modified.
|
Fix all CMakeLists now |
hugueskamba
approved these changes
Feb 15, 2021
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
added
release-version: 6.8.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMake targets matching Mbed OS targets, refactor. Tested for both of these end-targets
Summary of changes
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers