Release - Update custom target handling #2852
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theotherjimmy
force-pushed
the
release-candidate
branch
5 times, most recently
from
0117735 to
1195935
Compare
|
@theotherjimmy A better description please 👍 |
Accounts for the Config object owning a target, and TARGET_MAP not being a modify-able dict.
theotherjimmy
force-pushed
the
release-candidate
branch
from
1195935 to
f41fc43
Compare
theotherjimmy
changed the title
|
@sg- Better? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes tools exceptions caused by backporting #2757 without #2691
In particular, changes the way it which custom targets are handled after the config refactor.