bd: Fix missing const attributes on functions #3866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xc0170
approved these changes
Mar 2, 2017
|
/morph test-nightly |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputTest failed! |
|
I believe for the last run a HEXIWEAR had been knocked offline as the issue persisted in other CI runs. I have reset it so hopefully the same problem won't affect this run. /morph test-nightly |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
retest uvisor |
|
LGTM? |
|
Please confirm the spif-driver test https://github.com/ARMmbed/spiflash-driver/blob/master/TESTS/block_device/spif/main.cpp works with the new changes? If yes, then its OK to me to merge. |
|
Can confirm, the spiflash-driver repo and i2ceeprom-driver repo have both been updated to match this pr (tested locally) |
0xc0170
added
ready for merge
release-version: 5.4.1
and removed
needs: CI
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From review for #3762, several of the "getter" functions in the block device had the const attribute added. However, we forgot a few, which is especially annoying if they depend on each other.
cc @simonqhughes, @0xc0170