Fix NUC472 compile error, fix TRNG seed length check fail issue #5434
Conversation
Exporter Build : SUCCESSBuild number : 81 |
|
Can you please split these changes to 3 commits. They are not logical related , thus would make sense to have 3 - one for TRUE/FALSE if not defined, one for adding a button, and the last TRNG. They look simple, but having a problem with one would revert all 3, review, etc. Please provide a better description in the commit message why and how is it fixing a problem, this would lead also to splitting this one commit |
| } | ||
|
|
||
| if (*output_length != length) { | ||
| trng_get(tmpBuff) ; |
There was a problem hiding this comment.
tab or 8 spaces used for this block of code? we use 4 spaces. line 85 seems also out of alignment
|
@Ronny-Liu I am engineer of Nuvoton. Thanks for your evaluation of Mbed Cloud on our target NUMAKER_PFM_NUC472. About the issues your listed (TRUE/FALSE redefinition, button macro, and TRNG with non-32-byte aligned), we could have re-produced them and will raise related PRs separately to fix them. We have tried OK with Mbed Cloud on NUMAKER_PFM_NUC472, but it needs other bug-fixes besides above. Please suspend and wait for our update. |
5 participants
Notes:
Description
A few sentences describing the overall goals of the pull request's commits.
Status
READY/IN DEVELOPMENT/HOLD
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
YES | NO
Related PRs
List related PRs against other branches:
Todos
Deploy notes
Notes regarding the deployment of this PR. These should note any required changes in the build environment, tools, compilers and so on.
Steps to test or reproduce
Outline the steps to test or reproduce the PR here.