Skip to content

Fix fatal parameter error when deleting/terminating Thread object #5587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 20, 2017
Merged

Fix fatal parameter error when deleting/terminating Thread object #5587

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c721ed8
Fatal parameter error when deleting/terminating Thread object
marogi Nov 25, 2017
c08e0f5
Fixed whitespace
marogi Nov 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion rtos/Thread.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,11 @@ osStatus Thread::terminate() {
_tid = (osThreadId_t)NULL;
if (!_finished) {
_finished = true;
ret = osThreadTerminate(local_id);
// if local_id == 0 Thread was not started in first place
// and does not have to be terminated
if (local_id != 0) {
ret = osThreadTerminate(local_id);
}
}
_mutex.unlock();
return ret;
Expand Down