Mbed os 5.8 simulator support #6457

janjongboom · 2018-03-26T14:31:12Z

Description

Just opening this pull request to spark some discussion. This is adding a new simulator target to Mbed OS 5.8. It modifies a couple of files (Ticker.h which I think fixes a bug, and mbed_retarget.h, which I'm not sure how to fix otherwise, and then some changes in netsocket so it does not require RTOS, which I think is a bug too). In addition you'll notice that some files are overridden in the simulator target folder. These are swapped out in the build process for the simulator, so not through Mbed CLI at this point.

The reason that I want this in Mbed OS core is that it should be much easier to keep up to date. In addition I'd like to have support for this in CLI as well, and integrate this nicely in our tools. This is not something we can do in a single release, but by adding it to the core at least we know when we break something.

Opinions?

This branch is used in https://github.com/janjongboom/mbed-simulator/tree/upstream-mbed-os by the way, which updates the simulator branch to this version of Mbed OS. Work in progress of course.

Pull request type

[ ] Fix
[ ] Refactor
[X] New target
[X] Feature
[ ] Breaking change

theotherjimmy · 2018-03-27T14:53:47Z

@janjongboom It looks like this is based on 5.8. As it stands, this is fine for discussion, but it could not be merged to master until you rebase it onto master. That will avoid duplicating all of the other commits onto master.

theotherjimmy · 2018-03-27T14:55:40Z

FYI @SenRamakri Those tools changes are already on master. As you can see in the history, I made those commits.

cmonr · 2018-03-27T14:55:44Z

@janjongboom Simple question to kick things off. Could you rebase your branch to make this commit history simpler to follow? Looks like the branch is quite a ways off from master right now.

janjongboom · 2018-03-28T11:56:28Z

@cmonr @theotherjimmy Rebased on top of master.

theotherjimmy · 2018-03-28T15:11:39Z

@janjongboom It looks like you still have 2 "add mbed version block" commits. Could you remove them?

0xc0170 · 2018-04-04T13:47:37Z

drivers/Ticker.h

@@ -115,9 +115,11 @@ class Ticker : public TimerEvent, private NonCopyable<Ticker> {
    void attach_us(Callback<void()> func, us_timestamp_t t) {
        core_util_critical_section_enter();
        // lock only for the initial callback setup and this is not low power ticker
+#if DEVICE_SLEEP


this fix should be a separate PR ! We provide empty implementation fro sleep manager so it would end up being removed anyway (does not need to have sleep protect in the user code).

0xc0170 · 2018-04-04T13:49:49Z

mbed.h

@@ -16,6 +16,23 @@
 #ifndef MBED_H
 #define MBED_H

+#define MBED_LIBRARY_VERSION 160


As pointed earlier, this should not be part of this branch

0xc0170 · 2018-04-04T13:50:30Z

targets/TARGET_SIMULATOR/analogout_api.c

@@ -0,0 +1,42 @@
+#include <math.h>


Add license header in new files please

0xc0170 · 2018-04-04T13:50:42Z

targets/TARGET_SIMULATOR/analogout_api.c

+#include "objects.h"
+#include "emscripten.h"
+
+void analogout_init(dac_t *obj, PinName pin) {


{ new line for function body

0xc0170 · 2018-04-04T13:51:36Z

features/netsocket/UDPSocket.cpp

@@ -23,7 +23,11 @@
 #define WRITE_FLAG          0x2u

 UDPSocket::UDPSocket()
+#ifdef MBED_CONF_RTOS_PRESENT


Which files in this PR are needed to be non-rtos? Why is this being added?

UDPSocket and TCPSocket are currently only for RTOS because they need EventFlags. But they work fine without RTOS as long as you wrap the EventFlags things.

geky · 2018-04-05T14:05:19Z

events/equeue/equeue.c

+        // ok... so for some reason this is necessary
+        // no idea why, maybe something with blocks not actually allocated until we yield back
+        wait_ms(10);
+#endif


Hmmmm, yeah we need to look into this before this goes in.

geky · 2018-04-05T14:06:58Z

features/netsocket/UDPSocket.cpp

    _event_flag.set(READ_FLAG|WRITE_FLAG);
+#endif


I wonder if this would be better as a PlatformSemaphore (and PlatformEventFlags?).

Enable LoRaWAN in the simulator

cmonr · 2018-06-07T15:29:51Z

@janjongboom Do you think this would be better served to go into a feature branch?

As it stands, this PR makes a lot of small but deep changes to all aspects of Mbed OS, and would be easier to review with smaller commits.

janjongboom · 2018-06-08T20:00:06Z

@cmonr, yes, but I don't have push rights to Mbed so if I move it to a feature branch I can't work on it anymore ;-) Also I have an Mbed OS 5.9 branch.

But yes, would be good to discuss how we can this closer to upstream.

adbridge · 2018-06-14T15:39:58Z

@janjongboom The only people allowed push access to mbed-os are the maintainers. The way everyone else works is that we create a feature branch for them, they fork mbed-os, work on the feature branch in their fork and then when they want to drop code onto the ARMmbed version of the feature they create a PR from their fork.

cmonr · 2018-06-26T12:47:44Z

@janjongboom I've created the branch feature-simulator-target for this feature, and will be closing this PR.

You can open a PR against that branch for this feature.

janjongboom · 2018-07-09T01:56:37Z

@cmonr Thanks, will do.

cmonr · 2018-07-09T13:25:19Z

@janjongboom Remember, the smaller the changesets are, the quicker we can get the PRs reviewed ;)

0xc0170 added the needs: review label Mar 26, 2018

SenRamakri requested review from c1728p9, 0xc0170, SenRamakri, geky, deepikabhavnani, cmonr and theotherjimmy March 27, 2018 14:36

geky requested review from sg- and screamerbg March 27, 2018 14:42

adbridge and others added 12 commits March 28, 2018 13:54

Add Mbed version block for new minor release.

0649181

Update Mbed version block for patch release

4fee8e8

Don't call sleep_manager_lock_deep_sleep if device does not have sleep

cae73dd

Allow compiling against emscripten

6e22fe7

SIMULATOR target

6c456e1

Switch out platform/mbed_critical.cpp

a83bf7d

equeue should yield back to the browser

f8f6bb6

Enable netsocket to work without RTOS

074706c

Overload some COMMON_PAL functions

338f5ee

Begin implementing serial

2c520ff

Disable serial on simulator target for now

a973086

Bring back fdopen

ed75535

janjongboom force-pushed the mbed-os-5.8-simulator branch from 7e9b452 to ed75535 Compare March 28, 2018 11:55

Fix stream in simulator

80bb706

0xc0170 requested changes Apr 4, 2018

View reviewed changes

geky reviewed Apr 5, 2018

View reviewed changes

0xc0170 added needs: work and removed needs: review labels Apr 9, 2018

janjongboom added 11 commits April 20, 2018 12:54

Bring back Serial

d1d378c

LoRaWAN WIP

36e0340

More or less working version that does tx

7081212

Remove debug info

d926ade

Two-way data working

f3356e6

Add timestamp_ms to radio

0bdfa31

Don't pause in events malloc when dispatch was never called, weird quirk

9175ea7

Add mbed-trace support to simulator

0b56a38

Revert some logic back to upstream

2ffe2e2

Merge pull request #1 from janjongboom/lorawan

99269f2

Enable LoRaWAN in the simulator

Don't include types in simulator

b2fe11e

cmonr closed this Jun 26, 2018

0xc0170 removed the needs: work label Jun 26, 2018

		_event_flag.set(READ_FLAG\|WRITE_FLAG);
		#endif

Mbed os 5.8 simulator support #6457

Mbed os 5.8 simulator support #6457

Uh oh!

Conversation

janjongboom commented Mar 26, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Pull request type

Uh oh!

theotherjimmy commented Mar 27, 2018

Uh oh!

theotherjimmy commented Mar 27, 2018

Uh oh!

cmonr commented Mar 27, 2018

Uh oh!

janjongboom commented Mar 28, 2018

Uh oh!

theotherjimmy commented Mar 28, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 Apr 4, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cmonr commented Jun 7, 2018

Uh oh!

janjongboom commented Jun 8, 2018

Uh oh!

adbridge commented Jun 14, 2018

Uh oh!

cmonr commented Jun 26, 2018

Uh oh!

janjongboom commented Jul 9, 2018

Uh oh!

cmonr commented Jul 9, 2018

Uh oh!

Uh oh!

janjongboom commented Mar 26, 2018 •

edited

Loading

0xc0170 Apr 4, 2018 •

edited

Loading