Skip to content

STM32 SPI: fix NSS pin configuration #6951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2018
Merged

STM32 SPI: fix NSS pin configuration #6951

merged 1 commit into from
May 21, 2018

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented May 18, 2018 •
edited
Loading

Description

The NSS pin initialization was not done when the NSS pin was not NC. This fixes issue #6888

Pull request type

    [X] Fix
    [ ] Refactor
    [ ] New target
    [ ] Feature
    [ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented May 20, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented May 20, 2018

Build : SUCCESS

Build number : 2076
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6951/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented May 20, 2018

Test : SUCCESS

Build number : 1886
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6951/1886

@mbed-ci
Copy link

mbed-ci commented May 20, 2018

Exporter Build : SUCCESS

Build number : 1721
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6951/

cmonr
cmonr approved these changes May 21, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay, small fix!

@cmonr cmonr merged commit ea13262 into ARMmbed:master May 21, 2018
@studavekar studavekar mentioned this pull request May 21, 2018
Closed
@bcostm bcostm deleted the fix_spi_nss_config branch July 3, 2018 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+1 more reviewer

@cmonr cmonr cmonr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.8.6

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@bcostm @0xc0170 @mbed-ci @cmonr