Skip to content

Lora: Add support for runtime PHY selection #7430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2018
Merged

Lora: Add support for runtime PHY selection #7430

merged 2 commits into from
Jul 11, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Jul 6, 2018

Description

Add support to set up lora stack using user given PHY object. This will enable PHY selection at run time (usefull for example to roaming devices).

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

Lora: Add initialize() method to set LoRaWANTimeHandler class for phy
50004ca 
Instead of giving LoRaWANTimeHandler object as parameter for constructor,
object is now given via own initialize() method.

This change is needed for future refactoring where application can give own
PHY object for LoRa stack.
@kivaisan
Copy link
Contributor Author

kivaisan commented Jul 6, 2018

@hasnainvirk, @kjbracey-arm, please review.

hasnainvirk
hasnainvirk reviewed Jul 6, 2018
View reviewed changes
features/lorawan/LoRaWANStack.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LoRaRadio& radio -> LoRaRadio &radio

features/lorawan/LoRaWANInterface.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add doc for the first parameter as well.

@kivaisan
Copy link
Contributor Author

kivaisan commented Jul 6, 2018

@hasnainvirk please review again.

hasnainvirk
hasnainvirk previously approved these changes Jul 6, 2018
View reviewed changes
features/lorawan/LoRaWANInterface.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style fix here. LoRaRadio& radio -> LoRaRadio &radio

features/lorawan/LoRaWANStack.cpp Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style fix here. LoRaRadio &raido

features/lorawan/LoRaWANStack.h Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style fix LoRaRadio &radio

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is good already but I fixed some other radio style bugs.

Lora: Support user provided LoRaPHY object
0397b0b 
To support custom PHY object, a new LoRaWANInterface constructor was
added.
@hasnainvirk
Copy link
Contributor

@kjbracey-arm Can you please spare some time to review this ?

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2018

Build : SUCCESS

Build number : 2551
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7430/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2018

Test : SUCCESS

Build number : 2308
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7430/2308

@mbed-ci
Copy link

mbed-ci commented Jul 9, 2018

Exporter Build : SUCCESS

Build number : 2196
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7430/

@cmonr
Copy link
Contributor

cmonr commented Jul 11, 2018

Looks good to go!

@cmonr cmonr merged commit 3f742c9 into ARMmbed:master Jul 11, 2018
@cmonr cmonr mentioned this pull request Jul 16, 2018
Merged
pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018
Merge pull request ARMmbed#7430 from kivaisan/user_constructed_phy_v2
7825218 
Lora: Add support for runtime PHY selection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@kjbracey kjbracey kjbracey approved these changes

@hasnainvirk hasnainvirk hasnainvirk left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.10.0-rc1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kivaisan @hasnainvirk @0xc0170 @mbed-ci @cmonr @kjbracey