Skip to content

Fix linker script for NRF52840/ARM #7502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix linker script for NRF52840/ARM #7502

wants to merge 1 commit into from

Conversation

marcuschangarm
Copy link
Contributor

Description

Add missing noinit section.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Fix linker script for NRF52840/ARM
eecdcd9 
Add missing noinit section.
@marcuschangarm marcuschangarm mentioned this pull request Jul 12, 2018
Closed
@cmonr cmonr requested a review from naveenkaje July 12, 2018 16:04
0xc0170
0xc0170 requested changes Jul 12, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That space in the other file should be separate commit (not related to nvictable addition), otherwise LGTM

@0xc0170
Copy link
Contributor

0xc0170 commented Jul 13, 2018 •
edited
Loading

I assume this #7505 replaces this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 requested changes

@naveenkaje naveenkaje Awaiting requested review from naveenkaje

+1 more reviewer

@cmonr cmonr cmonr approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marcuschangarm @0xc0170 @cmonr