Skip to content

Reset channel settings back to default #8298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2018
Merged

Reset channel settings back to default #8298

merged 1 commit into from
Oct 10, 2018

Conversation

SeppoTakalo
Copy link
Contributor

Description

Reset channel settings back to default after changing channels in WiFi test.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@SeppoTakalo SeppoTakalo mentioned this pull request Oct 2, 2018
Closed
@0xc0170 0xc0170 requested a review from a team October 2, 2018 10:44
asifrizwanubx
asifrizwanubx approved these changes Oct 2, 2018
View reviewed changes
Copy link
Contributor

@asifrizwanubx asifrizwanubx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@SeppoTakalo
Copy link
Contributor Author

@0xc0170 Please run the tests.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

The only test we can run is build, test + exporters will fail due to reported issues

@AmmadRehmatCUS
Copy link

Is it due to any reported issues in this fix or some other fix?

The only test we can run is build, test + exporters will fail due to reported issues

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 4, 2018

@AmmadRehmat #8297 - exporters currently. Tests should be fine.

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 4, 2018

Build : SUCCESS

Build number : 3235
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8298/

Triggering tests

/morph test
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 5, 2018

Test : SUCCESS

Build number : 3040
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8298/3040

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 9, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Oct 9, 2018

Exporter Build : SUCCESS

Build number : 2927
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8298/

@cmonr cmonr merged commit 5a47318 into ARMmbed:master Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@asifrizwanubx asifrizwanubx asifrizwanubx approved these changes

@VeijoPesonen VeijoPesonen VeijoPesonen approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.10.2

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@SeppoTakalo @0xc0170 @AmmadRehmatCUS @mbed-ci @asifrizwanubx @VeijoPesonen @cmonr