Skip to content

Conversation

adamheinrich
Copy link
Contributor

Description

This enables Flash IAP (In-Application Programming) support for STM32F407VG on DISCO_F407VG and ARCH_MAX platforms.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@cmonr cmonr requested a review from a team November 8, 2018 16:48
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bcostm
Copy link
Contributor

bcostm commented Nov 9, 2018

LGTM too. Did you run the Flash IAP tests ?

Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have executed ST CI tests:

target platform_name test suite result elapsed_time (sec) copy_method
DISCO_F407VG-ARM DISCO_F407VG tests-mbed_drivers-flashiap OK 34.49 default
DISCO_F407VG-ARM DISCO_F407VG tests-mbed_hal-flash OK 19.96 default
DISCO_F407VG-GCC_ARM DISCO_F407VG tests-mbed_drivers-flashiap OK 35.33 default
DISCO_F407VG-GCC_ARM DISCO_F407VG tests-mbed_hal-flash OK 20.68 default
DISCO_F407VG-IAR DISCO_F407VG tests-mbed_drivers-flashiap OK 34.0 default
DISCO_F407VG-IAR DISCO_F407VG tests-mbed_hal-flash OK 19.77 default

@cmonr
Copy link
Contributor

cmonr commented Nov 9, 2018

Note: This PR is now a part of a rollup PR (#8694).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.

If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@cmonr cmonr merged commit 02ea9ce into ARMmbed:master Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants