Skip to content

Fix FLASHIAP_ROM_END macro for GCC_ARM & IAR toolchains #9148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2018
Merged

Fix FLASHIAP_ROM_END macro for GCC_ARM & IAR toolchains #9148

merged 1 commit into from
Dec 20, 2018

Conversation

davidsaada
Copy link
Contributor

Description

  • Consider data section in GCC_ARM toolchain
  • Consider init_array section in IAR toolchain
  • Rename macro to FLASHIAP_APP_ROM_END_ADDR for clarity sake

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Fix FLASHIAP_ROM_END macro for GCC_ARM & IAR toolchains
f3bac34 
- Consider data section in GCC_ARM toolchain
- Consider init_array section in IAR toolchain
- Rename macro to FLASHIAP_APP_ROM_END_ADDR for clarity sake
@ciarmcom ciarmcom requested review from a team December 19, 2018 12:00
@ciarmcom
Copy link
Member

@davidsaada, thank you for your changes.
@ARMmbed/mbed-os-test @ARMmbed/mbed-os-core @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-maintainers please review.

@davidsaada davidsaada mentioned this pull request Dec 19, 2018
Closed
cmonr
cmonr approved these changes Dec 19, 2018
View reviewed changes
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's see what CI has to say.

@cmonr
Copy link
Contributor

cmonr commented Dec 19, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 19, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 85c2fc7 into ARMmbed:master Dec 20, 2018
@davidsaada davidsaada deleted the david_fix_app_end_addr branch January 14, 2019 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+2 more reviewers

@cmonr cmonr cmonr approved these changes

@dannybenor dannybenor dannybenor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.11.1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@davidsaada @ciarmcom @cmonr @mbed-ci @0xc0170 @dannybenor