Skip to content

Clarify addition to CONFIGURATION.md #9403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2019
Merged

Clarify addition to CONFIGURATION.md #9403

merged 1 commit into from
Jan 18, 2019

Conversation

AnotherButler
Copy link
Contributor

Description

Rephrase for clarity.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ X] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@yossi2le

Clarify addition to CONFIGURATION.md
29b3ed9 
Rephrase for clarity.
@cmonr cmonr requested a review from a team January 16, 2019 23:47
theamirocohen
theamirocohen approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@theamirocohen theamirocohen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

yossi2le
yossi2le approved these changes Jan 17, 2019
View reviewed changes
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AnotherButler for the help :)

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 17, 2019

CI started

@cmonr cmonr merged commit ce1bb59 into master Jan 18, 2019
@0xc0170 0xc0170 deleted the AnotherButler-patch-1 branch February 21, 2019 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

+3 more reviewers

@cmonr cmonr cmonr approved these changes

@theamirocohen theamirocohen theamirocohen approved these changes

@yossi2le yossi2le yossi2le approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-version: 5.11.3

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AnotherButler @0xc0170 @cmonr @theamirocohen @yossi2le