Skip to content

Conversation

theamirocohen
Copy link
Contributor

@theamirocohen theamirocohen commented Jan 29, 2019

Description

FlashIAPBlockDevice LittleFS ‘fopen’ falls on nightly tests (https://mbed-os.mbedcloudtesting.com/job/mbed-os-ci_greentea-test-nightly/101/testReport/).
LittleFS test on FlashIAP is not relevant and thus removed.
The general blockdevice tests (https://github.com/ARMmbed/mbed-os/tree/master/features/storage/TESTS/blockdevice/general_block_device) will be expanded to further validate FlashIAPBlockDevice.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[X] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-storage

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

Please review, thanks!

Use Reviewers section in the description that is checked by bot (if not already included in implicit reviewers list)

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message lacks a reason for this removal

FlashIAPBlockDevice LittleFS ‘fopen’ falls on nightly tests
LittleFS test on FlashIAP is not relevant and thus removed
Copy link
Contributor

@yossi2le yossi2le left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmonr
Copy link
Contributor

cmonr commented Jan 29, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 30, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@0xc0170 0xc0170 merged commit 88d7ef1 into ARMmbed:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants