feat: allow xpath for test regression against element + Windows support #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warning: This patch does two things, which I sadly didn't have time to split out into separate PRs. 1) Allow a user to give an optional `xpath` qualifier when calling `screenshot_regression`. The regression will then be tested against this single element instead of the whole page. 2) Make pytest-image-diff with splinter work properly on Windows (see issue #1). Since Windows requires us to close the temp file first, we make the temp file persistent, close it, and then tells splinter to write to it. Afterwards we clean up the temporary file before returning from the function.
Codecov Report
@@ Coverage Diff @@
## master #2 +/- ##
===========================================
- Coverage 54.89% 41.56% -13.33%
===========================================
Files 6 6
Lines 235 243 +8
Branches 40 42 +2
===========================================
- Hits 129 101 -28
- Misses 94 131 +37
+ Partials 12 11 -1
Continue to review full report at Codecov.
|
|
Seems like the |
|
Hello! |
matslindh
deleted the
add-xpath-to-screenshot-regression-and-windows-compatibility-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warning: This patch does two things, which I sadly didn't have time to split out into separate PRs.
xpathqualifier when callingscreenshot_regression. The regression will then be tested against this single element instead of the whole page.