feat(ui): implement retry logic for contributors list in About screen#633
Closed
RajnishKMehta wants to merge 2 commits into
Closed
feat(ui): implement retry logic for contributors list in About screen#633RajnishKMehta wants to merge 2 commits into
RajnishKMehta wants to merge 2 commits into
Conversation
- Made fetchContributorsFromGitHub() in AboutViewModel public to allow manual refresh. - Updated ErrorCard in AboutScreen to include a "Retry" button. - Connected the "Retry" button to the ViewModel's fetch method. - Used consistent styling with existing UI components (FilledTonalButton with 14dp rounded corners).
Review or Edit in CodeSandboxOpen the branch in Web Editor • VS Code • Insiders |
Contributor
Author
|
El flujo de trabajo está fallando con el error "403: Resource not accessible by integration" al intentar publicar un comentario en el PR. Parece que GitHub Actions no tiene los permisos necesarios para crear o actualizar comentarios en pull requests. Es posible que debas habilitar los permisos adecuados para los workflows:
Sin permisos de escritura, el workflow no puede crear ni eliminar comentarios en los pull requests.
|
Contributor
Author
|
Implemented 577194d |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements a retry mechanism for the contributors list in the About screen.
Key changes:
Technically, this uses the existing AboutViewModel state management and consistent Material 3 styling with FilledTonalButton and RoundedCornerShape(14.dp) as seen elsewhere in the screen.