Set Connection header as close when connection pooling is disabled, partial fix for #254

Grizzly provider fails on
GrizzlyBasicAuthTest.basicAuthFileNoKeepAliveTest

Author: Stephane Landelle

api/src/main/java/com/ning/http/client/providers/jdk/JDKAsyncHttpProvider.java

@@ -491,7 +491,7 @@ private void configure(URI uri, HttpURLConnection urlConnection, Request request
                 }
             }
 
-            String ka = config.getAllowPoolingConnection() ? "keep-alive" : "close";
+            String ka = AsyncHttpProviderUtils.keepAliveHeaderValue(config);
             urlConnection.setRequestProperty("Connection", ka);
             ProxyServer proxyServer = ProxyUtils.getProxyServer(config, request);
             if (proxyServer != null) {

api/src/main/java/com/ning/http/util/AsyncHttpProviderUtils.java

@@ -599,4 +599,8 @@ public static void checkBodyParts(int statusCode, Collection<HttpResponseBodyPar
             throw new IllegalStateException(BODY_NOT_COMPUTED);
         }
     }
+
+    public static String keepAliveHeaderValue(AsyncHttpClientConfig config) {
+        return config.getAllowPoolingConnection() ? "keep-alive" : "close";
+    }
 }

providers/netty/src/main/java/com/ning/http/client/providers/netty/NettyAsyncHttpProvider.java

@@ -705,12 +705,12 @@ else if (uri.getRawQuery() != null)
         }
 
         if (!webSocket && !request.getHeaders().containsKey(HttpHeaders.Names.CONNECTION)) {
-            nettyRequest.setHeader(HttpHeaders.Names.CONNECTION, "keep-alive");
+            nettyRequest.setHeader(HttpHeaders.Names.CONNECTION, AsyncHttpProviderUtils.keepAliveHeaderValue(config));
         }
 
         if (proxyServer != null) {
             if (!request.getHeaders().containsKey("Proxy-Connection")) {
-                nettyRequest.setHeader("Proxy-Connection", "keep-alive");
+                nettyRequest.setHeader("Proxy-Connection", AsyncHttpProviderUtils.keepAliveHeaderValue(config));
             }
 
             if (proxyServer.getPrincipal() != null) {

providers/netty/src/test/java/com/ning/http/client/providers/netty/NettyBasicAuthTest.java

@@ -21,6 +21,7 @@
 import com.ning.http.client.AsyncHttpClientConfig;
 import com.ning.http.client.async.BasicAuthTest;
 
+@Test
 public class NettyBasicAuthTest extends BasicAuthTest {
 
     @Override