Skip to content

Netty: Set Connection header to close instead of keep-alive if connection pooling is disabled #254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Mar 14, 2013 · 3 comments
Closed

Netty: Set Connection header to close instead of keep-alive if connection pooling is disabled #254

slandelle opened this issue Mar 14, 2013 · 3 comments
Assignees
@slandelle
Milestone
1.7.12

Comments

@slandelle
Copy link
Contributor

No description provided.

@ghost ghost assigned slandelle Mar 14, 2013
slandelle pushed a commit that referenced this issue Mar 14, 2013
Set Connection header as close when connection pooling is disabled, p…
14667e0 
…artial fix for #254

Grizzly provider fails on
GrizzlyBasicAuthTest.basicAuthFileNoKeepAliveTest
@slandelle
Copy link
Contributor Author

@rlubke Couldn't make it work for Grizzly provider, failed on GrizzlyBasicAuthTest.basicAuthFileNoKeepAliveTest

slandelle pushed a commit that referenced this issue Mar 14, 2013
Backport partial fix for #254
b583ca5
@vpnwr
Copy link

vpnwr commented Jul 2, 2013

I am curious, what is the reason for not allowing keep-alive if connection pooling is disabled?
thanks.

@slandelle
Copy link
Contributor Author

Because with the current design, ConnectionsPool is the only thing that can hold a reference to a connection between requests.

cs-workco pushed a commit to cs-workco/async-http-client that referenced this issue Apr 13, 2023
@artemredkin
fix test and a crash when closed (AsyncHttpClient#254)
a61b31c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
None yet
Projects
None yet
Milestone
1.7.12
Development

No branches or pull requests
2 participants
@slandelle @vpnwr