Skip to content

Commit 35cdab3

Browse files
author
Stephane Landelle
committed
Rename sendTextMessage into sendMessage and streamText into stream, close #671
1 parent 8b6f5db commit 35cdab3

File tree

5 files changed

+14
-14
lines changed

5 files changed

+14
-14
lines changed

src/main/java/com/ning/http/client/providers/grizzly/GrizzlyAsyncHttpProvider.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2705,13 +2705,13 @@ public WebSocket stream(byte[] fragment, int offset, int len, boolean last) {
27052705
}
27062706

27072707
@Override
2708-
public WebSocket sendTextMessage(String message) {
2708+
public WebSocket sendMessage(String message) {
27092709
gWebSocket.send(message);
27102710
return this;
27112711
}
27122712

27132713
@Override
2714-
public WebSocket streamText(String fragment, boolean last) {
2714+
public WebSocket stream(String fragment, boolean last) {
27152715
gWebSocket.stream(last, fragment);
27162716
return this;
27172717
}

src/main/java/com/ning/http/client/providers/netty/ws/NettyWebSocket.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,13 +91,13 @@ public WebSocket stream(byte[] fragment, int offset, int len, boolean last) {
9191
}
9292

9393
@Override
94-
public WebSocket sendTextMessage(String message) {
94+
public WebSocket sendMessage(String message) {
9595
channel.write(new TextWebSocketFrame(message));
9696
return this;
9797
}
9898

9999
@Override
100-
public WebSocket streamText(String fragment, boolean last) {
100+
public WebSocket stream(String fragment, boolean last) {
101101
TextWebSocketFrame frame = new TextWebSocketFrame(fragment);
102102
frame.setFinalFragment(last);
103103
channel.write(frame);

src/main/java/com/ning/http/client/websocket/WebSocket.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@ public interface WebSocket extends Closeable {
5252
* @param message a text message
5353
* @return this.
5454
*/
55-
WebSocket sendTextMessage(String message);
55+
WebSocket sendMessage(String message);
5656

5757
/**
5858
* Allows streaming of multiple text fragments.
@@ -61,7 +61,7 @@ public interface WebSocket extends Closeable {
6161
* @param last flag indicating whether or not this is the last fragment.
6262
* @return this.
6363
*/
64-
WebSocket streamText(String fragment, boolean last);
64+
WebSocket stream(String fragment, boolean last);
6565

6666
/**
6767
* Send a <code>ping</ping> with an optional payload

src/test/java/com/ning/http/client/websocket/ProxyTunnellingTest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ public void onError(Throwable t) {
149149
}
150150
}).build()).get();
151151

152-
websocket.sendTextMessage("ECHO");
152+
websocket.sendMessage("ECHO");
153153

154154
latch.await();
155155
assertEquals(text.get(), "ECHO");

src/test/java/com/ning/http/client/websocket/TextMessageTest.java

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -232,7 +232,7 @@ public void onError(Throwable t) {
232232
}
233233
}).build()).get();
234234

235-
websocket.sendTextMessage("ECHO");
235+
websocket.sendMessage("ECHO");
236236

237237
latch.await();
238238
assertEquals(text.get(), "ECHO");
@@ -294,7 +294,7 @@ public void onError(Throwable t) {
294294
}
295295
}).build()).get();
296296

297-
websocket.sendTextMessage("ECHO");
297+
websocket.sendMessage("ECHO");
298298

299299
latch.await();
300300
assertEquals(text.get(), "ECHOECHO");
@@ -320,7 +320,7 @@ public void onMessage(String message) {
320320

321321
@Override
322322
public void onOpen(com.ning.http.client.websocket.WebSocket websocket) {
323-
websocket.sendTextMessage("ECHO").sendTextMessage("ECHO");
323+
websocket.sendMessage("ECHO").sendMessage("ECHO");
324324
}
325325

326326
@Override
@@ -372,8 +372,8 @@ public void onError(Throwable t) {
372372
}
373373
}).build()).get();
374374

375-
websocket.streamText("ECHO", false);
376-
websocket.streamText("ECHO", true);
375+
websocket.stream("ECHO", false);
376+
websocket.stream("ECHO", true);
377377

378378
latch.await();
379379
assertEquals(text.get(), "ECHOECHO");
@@ -414,10 +414,10 @@ public void onError(Throwable t) {
414414
}
415415
}).build()).get();
416416

417-
websocket.sendTextMessage("ECHO");
417+
websocket.sendMessage("ECHO");
418418
textLatch.await();
419419

420-
websocket.sendTextMessage("CLOSE");
420+
websocket.sendMessage("CLOSE");
421421
closeLatch.await();
422422

423423
assertEquals(text.get(), "ECHO");

0 commit comments

Comments
 (0)