Skip to content

Allow to manually specify a Content-Length on setBody(Publisher<ByteBuffer>) #1136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
schmitch opened this issue Apr 6, 2016 · 2 comments
Closed
Assignees
Milestone

Comments

@schmitch
Copy link
Contributor

schmitch commented Apr 6, 2016

Actually when running something like that:

 new RequestBuilder().setUrl("http://localhost:9004/").setMethod("POST").setBody(publisher).setContentLength(3)

while publisher is of type Publisher<ByteBuffer> the setContentLength will be ignored?! And a Header of type Transfer-Encoding: chunked will be added. However it would be great to set that manually on Streaming bodies so if a Content-Length is there it will be used else it's the old behavior. The use case is simple, stream data where the size is known or computed and the receiving client needs to know the Content-Length.

slandelle added a commit that referenced this issue Apr 7, 2016
Added a way to define a body for ReactiveStreams, close #1136
@slandelle slandelle added this to the 2.0.0 milestone Apr 7, 2016
@schmitch
Copy link
Contributor Author

schmitch commented Apr 7, 2016

@slandelle when do you create the next Milestone?

@slandelle
Copy link
Contributor

Done: 2.0.0-RC21 (sic)

@slandelle slandelle self-assigned this Apr 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants