Skip to content

RxJava module sporadic test failures #1292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Oct 27, 2016 · 1 comment
Closed

RxJava module sporadic test failures #1292

slandelle opened this issue Oct 27, 2016 · 1 comment
Labels
Defect

Comments

@slandelle
Copy link
Contributor 

testObserveError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.643 sec  <<< FAILURE!
java.lang.AssertionError: Not completed!
    at rx.observers.TestSubscriber.assertCompleted(TestSubscriber.java:352)
    at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveError(AsyncHttpObservableTest.java:98)

testObserveMultiple(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.03 sec  <<< FAILURE!
java.lang.AssertionError: Not completed!
    at rx.observers.TestSubscriber.assertCompleted(TestSubscriber.java:352)
    at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveMultiple(AsyncHttpObservableTest.java:121)

testObserveNoError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.007 sec  <<< FAILURE!
java.lang.AssertionError: Not completed!
    at rx.observers.TestSubscriber.assertCompleted(TestSubscriber.java:352)
    at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testObserveNoError(AsyncHttpObservableTest.java:78)

testToObservableError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.006 sec  <<< FAILURE!
java.lang.AssertionError: Not completed!
    at rx.observers.TestSubscriber.assertCompleted(TestSubscriber.java:352)
    at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testToObservableError(AsyncHttpObservableTest.java:58)

testToObservableNoError(org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest)  Time elapsed: 0.005 sec  <<< FAILURE!
java.lang.AssertionError: Not completed!
    at rx.observers.TestSubscriber.assertCompleted(TestSubscriber.java:352)
    at org.asynchttpclient.extras.rxjava.AsyncHttpObservableTest.testToObservableNoError(AsyncHttpObservableTest.java:38)

testAbort(org.asynchttpclient.extras.rxjava.single.AsyncHttpSingleTest)  Time elapsed: 0.012 sec  <<< FAILURE!
java.lang.AssertionError: Not completed!
    at rx.observers.TestSubscriber.assertCompleted(TestSubscriber.java:352)
    at org.asynchttpclient.extras.rxjava.single.AsyncHttpSingleTest.testAbort(AsyncHttpSingleTest.java:292)
twz123 added a commit to twz123/async-http-client that referenced this issue Nov 22, 2016
@twz123
Check for errors before checking for completion.
7e64b97 
Fixes AsyncHttpClient#1292. All the failing tests make requests to actual websites. Most
probably timeouts happened, but since the tests check for completion first,
any exceptions produced by the tests didn't show up. By changing the assertion
order to check for no errors first, and then for completion, any errors that
are emitted by the tests will be propagated, and not suppressed.
@twz123 twz123 mentioned this issue Nov 22, 2016
Merged
slandelle pushed a commit that referenced this issue Nov 22, 2016
@twz123 @slandelle
Check for errors before checking for completion. (#1310)
32a080e 
Fixes #1292. All the failing tests make requests to actual websites. Most
probably timeouts happened, but since the tests check for completion first,
any exceptions produced by the tests didn't show up. By changing the assertion
order to check for no errors first, and then for completion, any errors that
are emitted by the tests will be propagated, and not suppressed.
@slandelle
Copy link
Contributor Author

Actually #1310 is not a real fix, but improves error reporting in those tests.
Will reopen if issue happens again and we have more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Defect
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@slandelle