Skip to content

Reduce Base64::encode allocations #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
slandelle opened this issue Feb 2, 2017 · 0 comments
Closed

Reduce Base64::encode allocations #1344

slandelle opened this issue Feb 2, 2017 · 0 comments
Assignees
@slandelle
Labels
Enhancement
Milestone
2.0.28

Comments

@slandelle
Copy link
Contributor

Base64::encode allocate a new StringBuilder on every call, it could be pooled.
@slandelle slandelle added this to the 2.0.28 milestone Feb 2, 2017
@slandelle slandelle self-assigned this Feb 2, 2017
slandelle added a commit that referenced this issue Feb 2, 2017
@slandelle
Reduce Base64::encode allocations, close #1344
e6e3d18 
Motivation:

`Base64::encode` allocates a StringBuilder on every call.

Modifications:

* Extract `StringBuilderPool` from `SringUtils`
* Use such pool for `Base64::encode`

Result:

Less allocations
slandelle added a commit that referenced this issue Feb 2, 2017
@slandelle
Reduce Base64::encode allocations, close #1344
6fa5fb8 
Motivation:

`Base64::encode` allocates a StringBuilder on every call.

Modifications:

* Extract `StringBuilderPool` from `SringUtils`
* Use such pool for `Base64::encode`

Result:

Less allocations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@slandelle slandelle

Labels
Enhancement
Projects
None yet
Milestone
2.0.28
Development

No branches or pull requests
1 participant
@slandelle